Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVKPixelFormats: Add support for B5G6R5_UNORM_PACK16 and B5G5R5A1_UNORM_PACK16 using swizzle. #2383

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

squidbus
Copy link
Contributor

@squidbus squidbus commented Oct 19, 2024

Adds support for VK_FORMAT_B5G6R5_UNORM_PACK16 and VK_FORMAT_B5G5R5A1_UNORM_PACK16 using swizzles, same as how 4444 format variations are supported.

These formats are pretty broadly supported elsewhere, so it's helpful to have support for them out-of-the-box on Apple systems as well.

Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting.

LGTM.

Have you tested, to validate these work?

@squidbus
Copy link
Contributor Author

Have you tested, to validate these work?

Yes, both are tested in images.

@billhollings billhollings merged commit 8e1cb0f into KhronosGroup:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants