Add definition of cl_icdl extension.#886
Conversation
There was a problem hiding this comment.
This mostly looks really good. I have a few questions though:
-
Have you thought about how to publish this extension? Some possibilities:
- Don't publish it at all, just put it in this repo as an asciidoc document.
- Include it in the extension spec.
- Build it as a standalone HTML doc and publish it via the registry like an EXT or vendor extension.
-
Have you investigated using the generated asciidoctor dictionaries to help ensure a consistent look-and-feel in this extension spec? We probably wouldn't want to do this if we just left it as an asciidoc document since the GitHub rendering doesn't look as nice, but if we're intending to publish it as an HTML spec I'd strongly recommend at least looking into this.
|
To be completely honest, I am a bit lost. All the extensions I wrote have been just ASCII docs and I don't think they've been published. But, if we go the cl_ext route in the headers, maybe it makes sense to formally publish it. Would you have a preference? |
|
I'm totally open to alternatives but here's one possibility: Treat this extension like any EXT or vendor extension. This means:
Maybe we can discuss this as an open in tomorrow's teleconference? |
|
@bashbaug Thanks for the valuable input. I gave it a shot, what do you think? |
|
Tagging @vdanjean as he is credited in the extension author list. |
bashbaug
left a comment
There was a problem hiding this comment.
LGTM!
I checked and the header generation scripts "just worked" for this extension, pretty cool.
I'll leave this open for a couple more days just in case there are other comments, otherwise I'll merge first thing next week.
|
Merging as discussed in the March 28th teleconference. |
This is the formal definition of the cl_icdl extension that adds info queries to an OpenCL ICD loader.
The PR for the headers is here:
KhronosGroup/OpenCL-Headers#214
Once those two are merged, we can update the loader and remove the temporary definition there.