Merged
Conversation
bashbaug
approved these changes
Mar 28, 2023
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
LGTM. We should probably merge this as-is and ASAP to keep CI clean.
Since I think we'll need a similar fix elsewhere though (OpenCL-CLHPP, OpenCL-ICD-Loader, probably OpenCL-SDK), at some point we should investigate whether we can move from macos-11 to macos-latest now that we're explicitly installing gcc9.
Contributor
Author
Indeed. I most probably will do one for the ICD loader in the process of validating KhronosGroup/OpenCL-ICD-Loader#210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two Issues we've been having recently withe the CI: