Skip to content

Comments

CI Fixes#225

Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom
Kerilk:fix-ci
Mar 28, 2023
Merged

CI Fixes#225
bashbaug merged 2 commits intoKhronosGroup:mainfrom
Kerilk:fix-ci

Conversation

@Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Mar 28, 2023

This fixes two Issues we've been having recently withe the CI:

  • MacOS images are sometimes missing gcc-9, (seems to be transitioned out) so this checks for it and installs it if required.
  • Ubuntu 18.04 is deprecated, but as we run in a container we can safely update the Ubuntu version we are using so I bumped it to 20.04

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably merge this as-is and ASAP to keep CI clean.

Since I think we'll need a similar fix elsewhere though (OpenCL-CLHPP, OpenCL-ICD-Loader, probably OpenCL-SDK), at some point we should investigate whether we can move from macos-11 to macos-latest now that we're explicitly installing gcc9.

@Kerilk
Copy link
Contributor Author

Kerilk commented Mar 28, 2023

Since I think we'll need a similar fix elsewhere though (OpenCL-CLHPP, OpenCL-ICD-Loader, probably OpenCL-SDK), at some point we should investigate whether we can move from macos-11 to macos-latest now that we're explicitly installing gcc9.

Indeed. I most probably will do one for the ICD loader in the process of validating KhronosGroup/OpenCL-ICD-Loader#210

@bashbaug bashbaug merged commit 8c4f011 into KhronosGroup:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants