Skip to content

Comments

add code generation README#228

Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom
bashbaug:update-script-requirements
Apr 13, 2023
Merged

add code generation README#228
bashbaug merged 2 commits intoKhronosGroup:mainfrom
bashbaug:update-script-requirements

Conversation

@bashbaug
Copy link
Contributor

This PR tidies up a few minor issues related to the code generation PR #161:

  1. It adds a README for the header code generation, similar to the README for ICD loader dispatch table code generation.
  2. It bumps the version requirement for Mako from 1.1.0 to 1.2.2.

EwanC
EwanC previously approved these changes Apr 13, 2023
Co-authored-by: Ewan Crawford <ewan.cr@gmail.com>
@bashbaug
Copy link
Contributor Author

@EwanC would you mind approving these changes again? Applying your comma fix apparently dismissed your review 😄

Copy link
Contributor

@Kerilk Kerilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@bashbaug bashbaug merged commit 9dfa583 into KhronosGroup:main Apr 13, 2023
@bashbaug bashbaug deleted the update-script-requirements branch April 13, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants