Open
Conversation
Contributor
|
Out of curiosity, did you do any experiments disabling testing for the headers (by passing |
Contributor
Author
|
You are correct that it would save a lot of time. But I also looked at those numbers, and the overhead of cloning/configuring/building (without test)/Installing is quite significant. We could still disable testing when building the cache to save additional time when the refresh is required. @MathiasMagnus should chime in as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR caches the result of the Headers install rather than checking them out, configuring them, and rebuilding them (and their tests) for each job. The cache depends on the main last commit, and thus should be refreshed if the main branch of the Headers is updated.
This PR yields significant CI performance improvements even when the cache is refreshed.
Quantifying globally is difficult given that the number of runners vary, but based on individual task runtimes, speedups I observed are: