feat: add compatibility support for QNX Neutrino#248
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Mar 9, 2025
Merged
feat: add compatibility support for QNX Neutrino#248bashbaug merged 1 commit intoKhronosGroup:mainfrom
bashbaug merged 1 commit intoKhronosGroup:mainfrom
Conversation
skytxy
approved these changes
Mar 6, 2025
bashbaug
approved these changes
Mar 7, 2025
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
LGTM. I don't have an easy way to test these changes, but they shouldn't break any of our existing configs.
The CI failure is unrelated to your changes. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #149
Changes
This pull request adds support for QNX in the ICD loader by making the following changes:
Platform Definition
__QNXNTO__toicd_platform.hto properly define platform-specific path separators and directory symbols.Directory Enumeration Fix
d_typein directory entries. Adjustedicd_linux.cto use_DEXTRA_FIRST(dirEntry)->d_typewhen compiling for QNX.Environment Variable Handling
icd_linux_envvars.cto treat QNX like macOS, as QNX does not have asecure_getenvimplementation.Testing
These changes have been tested on Qualcomm SA8155P and SA8295P platforms:
QNX 7.0.0 _DEXTRA_FIRST reference
QNX 7.1 _DEXTRA_FIRST reference