Conversation
Contributor
|
Seems reasonable to me. I agree that it's more important to have consistent formatting than it is to have a specific formatting. It doesn't need to be done as part of this commit, but as part of the PR to perform the reformat could you also:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one possible way of resolving #67. This PR is pretty much just
clang-format -style=llvm -dump-config > .clang-format.In other words, I'm adopting the LLVM style here. If someone has strong opinions on certain options I'm happy to change them, but my thinking here was that by adopting a predefined style we can keep the bikeshedding to a minimum.
Once adopted, I can create a second PR to actually perform the reformat.