COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h: Include pcre.h #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRLF and LF were mixed in lots of files, confusing tools like `patch`.
This fixes a compilation error with libpcre-8.42: ``` error: conflicting declaration 'typedef struct real_pcre8_or_16 pcre' ``` Closes: KhronosGroup#547 Closes: KhronosGroup#570
…ils/include/COLLADABUPcreCompiledPattern.h In the previous commit COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h was changed to already include this header.
devurandom
force-pushed
the
fix/libpcre-8.42-compat
branch
from
732a3ec to
82b3edc
Compare
devurandom
added a commit
to devurandom/gentoo-patches
that referenced
this pull request
Jul 12, 2018
…8.42 See-Also: https://bugs.gentoo.org/651756 See-Also: KhronosGroup/OpenCOLLADA#547 See-Also: KhronosGroup/OpenCOLLADA#570 See-Also: KhronosGroup/OpenCOLLADA#582
|
FAILURE: exercise-opencollada-pull-request build #143
Pull Requests:
|
|
broken jenkins computer (HW failure).. |
|
I relaunched the build, but this is not a Jenkins issue only. for example: on windows: on mac: |
|
FAILURE: exercise-opencollada-pull-request build #150
Pull Requests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compilation error with libpcre-8.42:
Also remove inclusion of pcre.h from files already including COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h
Closes: #547
Closes: #570
Depends-On: #581