Unwrap VkInstance in set name/tag debug functions #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a layer to wrap the instance handle, and when the various Set Name/Tag debug functions are called, the passed structure may contain an instance handle which was previously not being unwrapped before calling down the chain. This caused renderdoc to crash, as the instance handle was not known to it.
|
CI Vulkan-Loader build queued with queue ID 15497. |
|
CI Vulkan-Loader build # 2104 running. |
|
CI Vulkan-Loader build # 2104 failed. |
MarkY-LunarG
approved these changes
Jul 31, 2023
|
Seems that github actions is stalled for an unknown reason - it has passed on my fork so I am going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a layer to wrap the instance handle, and when the various Set Name/Tag debug functions are called, the passed structure may contain an instance handle which was previously not being unwrapped before calling down the chain. This caused renderdoc to crash, as the instance handle was not known to it.
Fixes #1266