Enable CRT Warnings and fix them #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 16112. |
|
CI Vulkan-Loader build # 2109 passed. |
charles-lunarg
force-pushed
the
redo_remove_no_crt_warnings
branch
from
390548e
to
f127549
Compare
|
CI Vulkan-Loader build queued with queue ID 17517. |
|
CI Vulkan-Loader build # 2114 running. |
|
CI Vulkan-Loader build # 2114 failed. |
charles-lunarg
force-pushed
the
redo_remove_no_crt_warnings
branch
from
f127549
to
0b2b368
Compare
|
CI Vulkan-Loader build queued with queue ID 18008. |
|
CI Vulkan-Loader build # 2115 running. |
|
CI Vulkan-Loader build # 2115 passed. |
charles-lunarg
force-pushed
the
redo_remove_no_crt_warnings
branch
from
0b2b368
to
fa0c3f9
Compare
|
CI Vulkan-Loader build queued with queue ID 19270. |
|
CI Vulkan-Loader build # 2118 running. |
charles-lunarg
force-pushed
the
redo_remove_no_crt_warnings
branch
from
fa0c3f9
to
35d4488
Compare
|
CI Vulkan-Loader build queued with queue ID 19299. |
Fixes the many uses of strncpy and strncat to use versions of the functions which the CRT approves of. This means adding the length of the destination string as a parameter. The function loader_platform_combine_path was removed and the single use of it was replaced with a call to snprinf, which achieves the same goal. There are a few other functions that the CRT warns about, like fopen and the wide char version of strcpy. These were also replaced with the 'safe' functions.
charles-lunarg
force-pushed
the
redo_remove_no_crt_warnings
branch
from
35d4488
to
fdadfbe
Compare
|
CI Vulkan-Loader build queued with queue ID 19306. |
|
CI Vulkan-Loader build # 2120 running. |
|
CI Vulkan-Loader build # 2120 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRT_SECURE_NO_WARNINGS disables warnings from using strcpy & strcat as well as strncpy and strncat. This isn't likely a huge concern, but the more warnings the better typically.
This commit introduces loader_strncpy and loader_strncat which are platform generic versions. C11 added strncpy_s and strncat_s which are analogs to the win32 functions. But because this is a C99 project, these functions are not used.