Fix problems detected by CodeQL static analysis #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 51658. |
|
CI Vulkan-Loader build # 2187 running. |
1 similar comment
|
CI Vulkan-Loader build # 2187 running. |
charles-lunarg
force-pushed
the
fix_codeql_issues
branch
from
8458476
to
ebf6962
Compare
|
CI Vulkan-Loader build queued with queue ID 51671. |
1 similar comment
|
CI Vulkan-Loader build queued with queue ID 51671. |
|
CI Vulkan-Loader build # 2189 running. |
|
CI Vulkan-Loader build # 2189 passed. |
charles-lunarg
force-pushed
the
fix_codeql_issues
branch
from
ebf6962
to
15158f1
Compare
|
CI Vulkan-Loader build queued with queue ID 51741. |
|
CI Vulkan-Loader build # 2190 running. |
|
CI Vulkan-Loader build # 2190 passed. |
charles-lunarg
force-pushed
the
fix_codeql_issues
branch
from
15158f1
to
bf9147a
Compare
|
CI Vulkan-Loader build queued with queue ID 54212. |
3 types of issues were found: * Incorrect format specifiers * Not providing required format specifies * Using alloca in a loop There are multiple instances of alloca in loops, but to fix them would require significant refactoring. This commit includes 1 move of alloca inside a for loop to the outside, but this is because the logic was redoing work in a for loop that could have been done once at the start of the function.
charles-lunarg
force-pushed
the
fix_codeql_issues
branch
from
bf9147a
to
adf0a47
Compare
|
CI Vulkan-Loader build queued with queue ID 54223. |
|
CI Vulkan-Loader build # 2197 running. |
|
CI Vulkan-Loader build # 2197 passed. |
|
Merging because CI passed in my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 types of issues were found:
There are multiple instances of alloca in loops, but to fix them would require significant refactoring. This commit includes 1 move of alloca inside a for loop to the outside, but this is because the logic was redoing work in a for loop that could have been done once at the start of the function.