Test WEBGL_multi_draw with offsets 2 GB into a 4 GB typed array. #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case for Chromium bug https://crbug.com/395670641 and Emscripten bug emscripten-core/emscripten#17539 .
|
All 4 draw calls fail in current Chromium and pass with the fix for https://crbug.com/395670641 . |
shrekshao
approved these changes
Feb 14, 2025
|
Thanks @shrekshao for your review. Landing this now, and will expand out with more tests of the multi-draw BaseVertex/BaseInstance extension, as well as 16 GB Wasm heap tests. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 15, 2025
Reuse the Int32List and Uint32List typedefs from WebGLRenderingContextBase, which fixed many other entry points in the same way, using PassAsSpan and BufferSourceTypeNoSizeLimit. This also allowed the MakeSpan helpers and Impl functions to be removed from the multi-draw extensions, simplifying the code. Tested with forthcoming WebGL conformance test in KhronosGroup/WebGL#3716 . Fixed: 395670641 Change-Id: If3d528888a2348755c7445b0f9a1bc2075c63abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6270738 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#1420801}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case for Chromium bug https://crbug.com/395670641 and Emscripten bug emscripten-core/emscripten#17539 .