fix(vault): register config instance for automatic refresh updates #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatkookooguy
force-pushed
the
feature/fix-vault-register
branch
from
4c04984 to
73ad851
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #52 +/- ##
==========================================
- Coverage 34.36% 34.08% -0.28%
==========================================
Files 11 11
Lines 1004 1018 +14
Branches 242 246 +4
==========================================
+ Hits 345 347 +2
- Misses 601 610 +9
- Partials 58 61 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When loadSecrets is called with a class instead of an instance, the refresh manager couldn't update the config object on refresh. Fix: - Add registerConfigInstance() method to VaultIntegration - Call it after creating the config instance in initializeVault() - Store vaultMetadata for re-registration with the actual instance - Re-schedule refreshes with the instance reference This ensures that when secrets are rotated, the config object is automatically updated with the new values.
thatkookooguy
force-pushed
the
feature/fix-vault-register
branch
from
73ad851 to
fe94863
Compare
|
This PR is included in version 2.12.1-beta.2 🎉 The release is available on: |
|
This PR is included in version 2.12.2-beta.1 🎉 The release is available on: |
|
This PR is included in version 2.12.2 🎉 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loadSecrets is called with a class instead of an instance, the refresh manager couldn't update the config object on refresh.
Fix:
This ensures that when secrets are rotated, the config object is automatically updated with the new values.