Skip to content

Fix variable syntax and restrict output file permissions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assisted-by-ai wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix variable syntax and restrict output file permissions #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion usr/bin/update-torbrowser
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ download_fail_help_set() {
}

tb_run_function() {
[[ -v "${tb_skip_functions}" ]] || tb_skip_functions=''
[[ -v tb_skip_functions ]] || tb_skip_functions=''
Copy link
Copy Markdown
Contributor

@ArrayBolt3 ArrayBolt3 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted.

case $tb_skip_functions in
*"$@"*) log notice "Skipping '$*', because tb_skip_functions includes it."
return 0
Expand Down
2 changes: 1 addition & 1 deletion usr/libexec/tb-updater/version-parser
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ if not input_path.is_file():
sys.exit(2)
else:
try:
output_path.touch(mode=0o644, exist_ok=True)
output_path.touch(mode=0o600, exist_ok=True)
Copy link
Copy Markdown
Contributor

@ArrayBolt3 ArrayBolt3 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected, this adds no additional security. (For one, this doesn't actually set a file mode, the output file already exists because it was created by version-validator and Path().touch() doesn't adjust file mode on files that already exist, and for two, knowing the version that the user actually downloaded is virtually useless info. The only scenario I can imagine this stifling an attacker is if they were trying to read this file to see if an MITM attack succeeded, and any attacker that can do that probably has already taken over the end-user's machine.)

except Exception:
print_noisy("ERROR: Cannot access output file.")
sys.exit(2)
Expand Down