Replace inotifywait with polling in cgroup cleanup#37
Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Open
Replace inotifywait with polling in cgroup cleanup#37assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Conversation
…trained systems inotifywait consumes an inotify watch from the kernel's limited fs.inotify.max_user_watches pool, which can cause "ENOSPC: System limit for number of file watchers reached" on systems where other software (IDEs, file managers, etc.) already uses many watches. Replace with a polling loop (50 iterations * 0.1s = 5s timeout). Since cgroup.kill sends SIGKILL, draining should be near-instant, making polling perfectly adequate. This also fixes: - no timeout (script could hang forever if cgroup never drained) - no error handling if inotifywait failed to start - potential leaked inotifywait processes on signal interruption https://claude.ai/code/session_01V4XkxCqroKpfDZE2Jknmdx
Contributor
|
Accepted in ArrayBolt3@36e9838. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the cgroup cleanup logic to use polling instead of inotifywait, eliminating dependency on the kernel's limited inotify watch pool and preventing ENOSPC errors on watch-constrained systems.
Key Changes
cgroup.eventsup to 50 timesinotifywait_subshell_pidandinotifywait_fd, replacing withcgroup_drainedandpoll_countcgroup.killwrite before the polling loop (more logical flow)Implementation Details
cgroup.killsends SIGKILL, so draining is near-instantcgroup_drainedflag instead of relying on subshell exit statushttps://claude.ai/code/session_01V4XkxCqroKpfDZE2Jknmdx