Dynamic bot spawning based on target population #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n GameConfig.java and depending on the difference between the current population of Bots and the target population (or ratio) the decision is made which type of bot will be spawned next.
tim-we
requested changes
Jul 5, 2023
Comment on lines
28
to
30
| * @param world | ||
| * @param game | ||
| * @return |
There was a problem hiding this comment.
Either add descriptions to these or remove this part of the JavaDoc comment
| public record BotPopulationDistributionTarget(double stupidBotRatio, double kamikazeBotRatio, | ||
| double scaredBotRatio) { | ||
| public BotPopulationDistributionTarget { | ||
| assert (stupidBotRatio + kamikazeBotRatio + scaredBotRatio == 1.0); |
There was a problem hiding this comment.
Careful with exact floating point math. Better check for Math.abs(x1 + x2 + x3 - 1.0) < 1e-8
tim-we
changed the title
tim-we
requested changes
Jul 26, 2023
tim-we
added
enhancement
|
IMO we need to rethink this a bit. I would prefer the following algorithm:
Another option would be to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented dynamic bot spawning. The target ratios are now defined in
GameConfig.javaand depending on the difference between the current population of Bots and the target population (or ratio) the decision is made which type of bot will be spawned next.