Skip to content

⚡ Bolt: Remove redundant deepcopy in JSON processing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

⚡ Bolt: Remove redundant deepcopy in JSON processing #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/services/json_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
string values while preserving the original structure.
"""

import copy
from dataclasses import dataclass
from typing import Any, Callable, Optional

Expand Down Expand Up @@ -148,7 +147,8 @@ def mask_processor(text: str) -> tuple[str, list]:
masked_text, masked_entities = mask_text(text, entities)
return masked_text, entities # Return original entities for reporting

return process_json_recursive(copy.deepcopy(data), mask_processor)
# Optimization: process_json_recursive creates a new structure, so deepcopy is redundant
return process_json_recursive(data, mask_processor)


def redact_json(
Expand All @@ -173,7 +173,8 @@ def redact_processor(text: str) -> tuple[str, list]:
redacted_text, _ = redact_text(text, entities)
return redacted_text, entities

return process_json_recursive(copy.deepcopy(data), redact_processor)
# Optimization: process_json_recursive creates a new structure, so deepcopy is redundant
return process_json_recursive(data, redact_processor)


def process_json_with_mode(
Expand Down Expand Up @@ -230,5 +231,6 @@ def custom_processor(text: str) -> tuple[str, list]:
result = result[:entity.start] + MASK_TOKEN + result[entity.end:]
return result, detected

return process_json_recursive(copy.deepcopy(data), custom_processor)
# Optimization: process_json_recursive creates a new structure, so deepcopy is redundant
return process_json_recursive(data, custom_processor)

Loading