Update JSON Tool Definitions to match XML & add cwd context where relevant. Fix incorrect codebase_search removal
#3933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions' into mcowger/jsondescriptions
…'t available. managed indexing is not required for codebase_search
🦋 Changeset detectedLatest commit: f984b6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Confirmed fixes it for me too |
|
Does this PR fix the JSON call issue for the codebase_search tool? |
Contributor
Author
Yes, among other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The JSON tool definitions didn't match XML in most cases, and often lacked additional injected contextual information (especially
cwd). This PR updates these definitions to match XML, and provide thatcwdcontext where relevant.Implementation
cwd.codebase_searchif managed indexing wasn't available.Screenshots
NA
Get in Touch
mcowger