-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add ThinkingSpinner component and integrate into StatusIndicator #3964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
How does this indicate the model is actively processing? It appears to just be a spinner that doesn't use any incoming data to determine if the model is doing anything? In other words, if the model just stopped outputting tokens (which happens), this animation would suggest the opposite. |
|
Excellent change. In a separate PR I'd love to see this in the UI as well. |
@mcowger Could you please clarify what you mean by 'UI'? I'm guessing the extension? |
Yes, exactly. |
Got it. I will work on it tomorrow if I have time. |
|
EDIT: Fixed with new PR. |
Fixes #3812
Context
Replaces the static "Thinking..." text in the CLI status indicator with an animated spinner. This provides better visual feedback to users that the system is actively processing, improving the user experience during model thinking/streaming states.
Implementation
Created a new
ThinkingSpinnercomponent that:colorprop to match the themecolorprop to integrate with existing theme stylingUpdated
StatusIndicatorto useThinkingSpinnerinstead of static text whenisStreamingis true.Added comprehensive test coverage:
ThinkingSpinnercomponent covering default/custom colors, frame animation, cycling, and cleanupStatusIndicatortests to use fake timers and validate spinner integrationScreenshots
How to Test
pnpm test cli/src/ui/components/__tests__/ThinkingSpinner.test.tsxGet in Touch
N/A