Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinto App Registry #28

Merged
merged 48 commits into from
Jan 9, 2024
Merged

Kinto App Registry #28

merged 48 commits into from
Jan 9, 2024

Conversation

rrecuero
Copy link
Contributor

@rrecuero rrecuero commented Jan 4, 2024

  • NFT Metadata will hold description, name, image, terms and conditions... Developers will set it up through the developer portal and will receive a minted nft with the info.
  • On-chain we keep the rate limits and gas limits so every developer can limit the transactions that they are willing to pay for.
  • We keep on-chain also whether the app has signed the dsa

Adds migrations needed:

  • Deploys Kinto App Registry and creates Engen app. Funds it on the paymaster.
  • Deploys new wallet and upgrades all wallets
  • Deploys new KintoWalletFactory and upgrades it
  • Deploys new paymaster and upgrades it

Copy link

github-actions bot commented Jan 4, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

solc-version

Impact: Informational
Confidence: High

  • ID-0
    solc-0.8.23 is not recommended for deployment

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (cdcbb51) 73.72% compared to head (1f8cd4b) 75.67%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   73.72%   75.67%   +1.95%     
==========================================
  Files          10       13       +3     
  Lines         411      444      +33     
  Branches      113      118       +5     
==========================================
+ Hits          303      336      +33     
+ Misses         48       45       -3     
- Partials       60       63       +3     
Files Coverage Δ
src/sample/Counter.sol 100.00% <ø> (ø)
src/sample/CounterInitializable.sol 100.00% <100.00%> (ø)
src/viewers/KYCViewer.sol 76.92% <100.00%> (+1.92%) ⬆️
src/sample/OwnableCounter.sol 0.00% <0.00%> (ø)
src/wallet/KintoWallet.sol 72.44% <71.42%> (+0.27%) ⬆️
src/wallet/KintoWalletFactory.sol 74.46% <55.55%> (+0.55%) ⬆️
src/apps/KintoAppRegistry.sol 83.33% <83.33%> (ø)
src/paymasters/SponsorPaymaster.sol 73.68% <69.23%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

src/apps/KintoApp.sol Outdated Show resolved Hide resolved
src/apps/KintoApp.sol Outdated Show resolved Hide resolved
src/apps/KintoApp.sol Outdated Show resolved Hide resolved
src/apps/KintoApp.sol Outdated Show resolved Hide resolved
src/apps/KintoApp.sol Outdated Show resolved Hide resolved
src/apps/KintoApp.sol Outdated Show resolved Hide resolved
rrecuero and others added 10 commits January 8, 2024 09:11
Co-authored-by: Federico Martín Alconada Verzini <fedealconada@gmail.com>
Co-authored-by: Federico Martín Alconada Verzini <fedealconada@gmail.com>
Co-authored-by: Federico Martín Alconada Verzini <fedealconada@gmail.com>
Co-authored-by: Federico Martín Alconada Verzini <fedealconada@gmail.com>
test/KintoAppRegistry.t.sol Show resolved Hide resolved
src/wallet/KintoWallet.sol Outdated Show resolved Hide resolved
src/apps/KintoAppRegistry.sol Outdated Show resolved Hide resolved
src/apps/KintoAppRegistry.sol Outdated Show resolved Hide resolved
src/wallet/KintoWalletFactory.sol Show resolved Hide resolved
Copy link
Contributor

@fedealconada fedealconada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rrecuero rrecuero merged commit 703b98a into main Jan 9, 2024
9 checks passed
@rrecuero rrecuero deleted the kintoapps branch January 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants