Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic wallet fund #323

Merged
merged 4 commits into from
Dec 5, 2024
Merged

automatic wallet fund #323

merged 4 commits into from
Dec 5, 2024

Conversation

rrecuero
Copy link
Contributor

@rrecuero rrecuero commented Dec 4, 2024

Description

Wallet ops are now automatically sponsored by our kinto core app and we do not need extra txs or ops on the frontend or a lambda.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@rrecuero rrecuero requested a review from ylv-io December 4, 2024 22:43
Copy link

openzeppelin-code bot commented Dec 4, 2024

automatic wallet fund

Generated at commit: 921eab0329b4c4a8aef12c4e23d8377ab430a975

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

github-actions bot commented Dec 4, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (f4807b9) to head (921eab0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   88.79%   89.02%   +0.22%     
==========================================
  Files          42       41       -1     
  Lines        2482     2479       -3     
==========================================
+ Hits         2204     2207       +3     
+ Misses        278      272       -6     
Files with missing lines Coverage Δ
src/paymasters/SponsorPaymaster.sol 91.26% <100.00%> (+0.21%) ⬆️

... and 6 files with indirect coverage changes

…ting paymaster user operation when wallet is an app in SponsorPaymaster.t.sol.
…ses, and replace contract addresses in transaction logs and test artifacts for chain 7887.
@ylv-io ylv-io merged commit 9220f2d into main Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants