Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes 1K reward #328

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Removes 1K reward #328

merged 6 commits into from
Dec 14, 2024

Conversation

rrecuero
Copy link
Contributor

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@rrecuero rrecuero requested a review from ylv-io December 12, 2024 04:00
Copy link

openzeppelin-code bot commented Dec 12, 2024

Removes 1K reward

Generated at commit: 2136cdef4a4f8cf9577e5e3f7bd01667b909ffd0

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (edaa9a0) to head (2136cde).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   89.08%   89.05%   -0.04%     
==========================================
  Files          41       41              
  Lines        2493     2486       -7     
==========================================
- Hits         2221     2214       -7     
  Misses        272      272              
Files with missing lines Coverage Δ
src/liquidity-mining/RewardsDistributor.sol 95.94% <100.00%> (-0.36%) ⬇️
src/wallet/KintoWalletFactory.sol 97.91% <ø> (ø)

…add placeholder function in RewardsDistributor, and temporary call in KintoWalletFactory.
…fy migration script for new implementation deployment.
@ylv-io ylv-io merged commit a655118 into main Dec 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants