Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BridgerL2 Withdraw #336

Merged
merged 15 commits into from
Jan 16, 2025
Merged

BridgerL2 Withdraw #336

merged 15 commits into from
Jan 16, 2025

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Jan 9, 2025

…2 contract, update imports, and enhance test setup.

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

…2 contract, update imports, and enhance test setup.
Copy link

openzeppelin-code bot commented Jan 9, 2025

BridgerL2 Withdraw

Generated at commit: 63c1c32ef27e79fd1d50d87b9097a59c6a10267d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

github-actions bot commented Jan 9, 2025

Slither report

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.87%. Comparing base (f14e440) to head (f0f6ebd).

Files with missing lines Patch % Lines
src/bridger/BridgerL2.sol 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   88.65%   88.87%   +0.21%     
==========================================
  Files          41       41              
  Lines        2521     2579      +58     
==========================================
+ Hits         2235     2292      +57     
- Misses        286      287       +1     
Files with missing lines Coverage Δ
src/bridger/BridgerL2.sol 99.10% <98.36%> (-0.90%) ⬇️

ylv-io added 14 commits January 10, 2025 09:45
…ing and receiver checks, enhance test coverage with BridgeDataHelper, and include DAI_KINTO address in constants.
…yment logic, and introduce BridgerL2V12 with additional constructor parameters.
…ridgeVault function to handle arrays, and add corresponding tests and events.
…estWithdrawERC20, and update unit tests for srcPreHookCall scenarios.
…ontract address; update transaction hashes and logs in run-latest.json and run-1736952282.json; modify addresses.json to include BridgerL2V12-impl address.
…igner in BridgerL2.t.sol for read-only optimization.
…pdate fund-faucets script with BRIDGER_L2 address.
…ation script, add fallback function for ETH reception, and update test artifacts with new contract address.
@ylv-io ylv-io merged commit 164f36d into main Jan 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants