-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BridgerL2 Withdraw #336
Merged
Merged
BridgerL2 Withdraw #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 contract, update imports, and enhance test setup.
BridgerL2 Withdraw
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
rrecuero
approved these changes
Jan 9, 2025
Slither report |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 88.65% 88.87% +0.21%
==========================================
Files 41 41
Lines 2521 2579 +58
==========================================
+ Hits 2235 2292 +57
- Misses 286 287 +1
|
…ing and receiver checks, enhance test coverage with BridgeDataHelper, and include DAI_KINTO address in constants.
…o BridgerL2 contract.
…yment logic, and introduce BridgerL2V12 with additional constructor parameters.
…ridgeVault function to handle arrays, and add corresponding tests and events.
…estWithdrawERC20, and update unit tests for srcPreHookCall scenarios.
…t settings in BridgerL2 contract.
…ontract address; update transaction hashes and logs in run-latest.json and run-1736952282.json; modify addresses.json to include BridgerL2V12-impl address.
…70-upgrade_bridger_l2.s.sol file.
…igner in BridgerL2.t.sol for read-only optimization.
…pdate fund-faucets script with BRIDGER_L2 address.
…ation script, add fallback function for ETH reception, and update test artifacts with new contract address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…2 contract, update imports, and enhance test setup.
Description
Type of change
Checklist:
main
, or there's a description of how to mergeIssue Resolution