Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue3): Fix vue3 components remounting every time a key is added to state #22

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

alesgenova
Copy link
Member

No description provided.

@alesgenova alesgenova requested a review from jourdain February 16, 2024 17:33
@alesgenova
Copy link
Member Author

The codespell error is unrelated to this PR, it has to do with a typo in another commit message that ended up in the changelog

Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you trigger an event with {type: "new-keys", keys: [...] }. It won't be use right now, but could be useful down the road.

@alesgenova
Copy link
Member Author

Can you trigger an event with {type: "new-keys", keys: [...] }. It won't be use right now, but could be useful down the road.

Added the new-keys event, and actually refactored the fix to use it in TrameTemplate.js

@jourdain
Copy link
Collaborator

Commit message should be fix(vue3): prevent remounting when keys are added

No upper case after :

@jourdain
Copy link
Collaborator

jourdain commented Feb 16, 2024

you can also edit the codespell check to skip the changelog

@jourdain jourdain merged commit 6088de2 into master Feb 16, 2024
4 checks passed
@jourdain jourdain deleted the fix-vue3-remount branch February 16, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants