-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a JS lib to support trame-client API through an iframe #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Nov 18, 2024
jourdain
reviewed
Nov 18, 2024
jourdain
reviewed
Nov 18, 2024
jourdain
reviewed
Nov 18, 2024
jourdain
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a high level.
bourdaisj
force-pushed
the
support-cross-origin-parent-communication
branch
4 times, most recently
from
December 9, 2024 20:50
112f7da
to
34c96a8
Compare
similar to trame-client js-api, trame-iframe js-api provides an agnostic library that can be installed in a regular JS project. trame-iframe js-api could be installed in a host application (could be react/streamlit/vue/... based) to proxy the trame API calls through the iframe to the Communicator and the trame application. The goal is to replicate the trame-client js-api features to make it transparent to the consumer code. API: - trame.state.set - trame.state.update - trame.state.watch - trame.trigger This is still possible to directly interact with the Communicator from an host application by manually sending/listening to events.
bourdaisj
force-pushed
the
support-cross-origin-parent-communication
branch
2 times, most recently
from
December 11, 2024 15:59
6632f86
to
ea1cbfb
Compare
jourdain
reviewed
Dec 11, 2024
"vite": "^5.2.0" | ||
}, | ||
"dependencies": { | ||
"@kitware/trame-iframe-client": "/home/jules/projects/kitware/trame/repos/trame-iframe/js-lib/dist/trame-iframe.mjs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix that
bourdaisj
force-pushed
the
support-cross-origin-parent-communication
branch
from
December 11, 2024 16:02
ea1cbfb
to
817132b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses: Kitware/trame-client#29 for state watchers API