Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widgets): handle registration and state delivery #7

Merged
merged 11 commits into from
Aug 23, 2024
Merged

fix(widgets): handle registration and state delivery #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f4f878d
fix(widgets): handle registration and state delivery
jourdain Jun 21, 2024
7238b25
fix(camera): try to send camera update
jourdain Jun 21, 2024
6807b54
fix(camera): camera event working now
jourdain Aug 13, 2024
5a9f677
fix(widgets): Update state after widget is registered
jspanchu Aug 13, 2024
931ce43
fix(example): sync client camera on server
jspanchu Aug 13, 2024
9df7733
fix(examples): examples reviewed
jourdain Aug 13, 2024
b03dbcf
fix(camera): sync only camera state
jspanchu Aug 15, 2024
78d2c63
fix(example): enable http headers
jourdain Aug 16, 2024
d9cb473
docs(glyph): update to add reset camera buttons
jourdain Aug 23, 2024
521024e
fix(SharedArrayBuffer): automatically swicth based on server flag
jourdain Aug 23, 2024
e95249b
feat(camera): allow to push camera from server
jourdain Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/pyvista/drap2dsurf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def _ui(self):
):
if WASM:
self.html_view = vtklocal.LocalView(self.render_window)
# for w in self.widgets:
# self.html_view.register_widget(w)
for w in self.widgets:
self.html_view.register_widget(w)
else:
self.html_view = vtk_widgets.VtkRemoteView(
self.render_window, interactive_ratio=1
Expand Down
5 changes: 1 addition & 4 deletions examples/vtk/glyph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ def on_resolution_change(self, resolution, **kwargs):
@change("camera")
def on_camera_change(self, camera, **kwargs):
if camera is not None:
self.view_local.object_manager.RegisterState(json.dumps(camera))
# FIXME - need to only apply camera state
self.view_local.object_manager.UpdateObjectsFromStates()
# FIXME - bug end
self.view_local.object_manager.UpdateObjectFromState(json.dumps(camera))
jspanchu marked this conversation as resolved.
Show resolved Hide resolved
self.view_remote.update()

def reset_camera(self):
Expand Down
6 changes: 1 addition & 5 deletions vue-components/src/components/VtkLocal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,7 @@ export default {
observerTags.push([
cid,
sceneManager.addObserver(cid, "ModifiedEvent", () => {
// slow => python ./examples/pyvista/drap2dsurf.py --server
// state update => python ./examples/vtk/glyph.py --server
// FIXME
// slow but needed to make camera event working
// sceneManager.updateStatesFromObjects();
sceneManager.updateStateFromObject(cid);
jspanchu marked this conversation as resolved.
Show resolved Hide resolved
const cameraState = sceneManager.getState(cid);
emit("camera", cameraState);
}),
Expand Down
Loading