Merge pull request #504 from Kitware/camera-style-light

fix(Manipulators): Update light orientation if needed
Kitware · Jan 17, 2018 · 2d6066c · 2d6066c
2 parents 132a58b + 11ac939
commit 2d6066c
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/Sources/Interaction/Manipulators/TrackballPan/index.js b/Sources/Interaction/Manipulators/TrackballPan/index.js
@@ -85,6 +85,10 @@ function vtkTrackballPan(publicAPI, model) {
     }
 
     renderer.resetCameraClippingRange();
+
+    if (interactor.getLightFollowCamera()) {
+      renderer.updateLightsGeometryToFollowCamera();
+    }
   };
 }
 

diff --git a/Sources/Interaction/Manipulators/TrackballRoll/index.js b/Sources/Interaction/Manipulators/TrackballRoll/index.js
@@ -113,6 +113,10 @@ function vtkTrackballRoll(publicAPI, model) {
     camera.orthogonalizeViewUp();
 
     renderer.resetCameraClippingRange();
+
+    if (interactor.getLightFollowCamera()) {
+      renderer.updateLightsGeometryToFollowCamera();
+    }
   };
 }
 

diff --git a/Sources/Interaction/Manipulators/TrackballRotate/index.js b/Sources/Interaction/Manipulators/TrackballRotate/index.js
@@ -102,6 +102,10 @@ function vtkTrackballRotate(publicAPI, model) {
     camera.orthogonalizeViewUp();
 
     renderer.resetCameraClippingRange();
+
+    if (interactor.getLightFollowCamera()) {
+      renderer.updateLightsGeometryToFollowCamera();
+    }
   };
 }
 

diff --git a/Sources/Interaction/Manipulators/TrackballZoom/index.js b/Sources/Interaction/Manipulators/TrackballZoom/index.js
@@ -75,6 +75,10 @@ function vtkTrackballZoom(publicAPI, model) {
       camera.setPosition(cameraPos[0], cameraPos[1], cameraPos[2]);
       renderer.resetCameraClippingRange();
     }
+
+    if (interactor.getLightFollowCamera()) {
+      renderer.updateLightsGeometryToFollowCamera();
+    }
   };
 
   publicAPI.onPinch = (interactor) => {

diff --git a/Sources/Interaction/Manipulators/TrackballZoomToMouse/index.js b/Sources/Interaction/Manipulators/TrackballZoomToMouse/index.js
@@ -36,6 +36,10 @@ function vtkTrackballZoomToMouse(publicAPI, model) {
       renderer,
       interactor
     );
+
+    if (interactor.getLightFollowCamera()) {
+      renderer.updateLightsGeometryToFollowCamera();
+    }
   };
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -85,6 +85,10 @@ function vtkTrackballPan(publicAPI, model) { @@
         }
         renderer.resetCameraClippingRange();
+        if (interactor.getLightFollowCamera()) {
+          renderer.updateLightsGeometryToFollowCamera();
+        }
       };
     }
@@ Expand Down @@