fix(webxr): remove controllers rays when stopping XR #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bourdaisj @finetjul please review |
bourdaisj
reviewed
Feb 20, 2025
| const ren = model.renderWindow.getRenderable().getRenderers()[0]; | ||
| model.xrSession.inputSources.forEach((inputSource) => { | ||
| if (model.inputSourceToRay[inputSource.handedness]) { | ||
| ren.removeActor(model.inputSourceToRay[inputSource.handedness].actor); |
There was a problem hiding this comment.
why not destroying the pipeline instead of only removing/hiding actor?
|
I think this was mistakenly closed from the other issue. Re-opening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using
vtkWebXRRenderWindowHelperwithdrawControllersRay=true, rays are drawn to represent the controllersbut they are not removed when stopping the XR session. This leads to the camera not being centered correctly.
Here's a comparison of before starting the XR session and after stopping it:
Results
Thanks to this small fix, the rays' actors are removed when exiting the XR session, and the camera can be re-centered
Changes
When
vtkWebXRRenderWindowHelper.stopXR()is called, every ray's actor is removed so they are not visible anymore.PR and Code Checklist
npm run reformatto have correctly formatted codeTesting