Add missing __init__.py file #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented the folder dicom_anonymization_databases to be added in the pip package.
Pydicom 3 seems to change a few methods, making it uncompatible with the current dicom-anonymizer code.
|
Are there plans to support pydicom version 3 later? |
We do not plan to support Pydicom 3, but if there are features that you want to use from Pydicom 3, feel free to submit a PR. |
|
No pressing need. Just curious what triggered not going to the new version. I know pydicom 3 requires python >= 3.10, but this project needs compatibility down to 3.6. Is that the main reason for something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevented the folder dicom_anonymization_databases to be added in the pip package.