Add 'route' reference to Mount child scope#3152
Open
y2kbugger wants to merge 1 commit intoKludex:mainfrom
Open
Add 'route' reference to Mount child scope#3152y2kbugger wants to merge 1 commit intoKludex:mainfrom
y2kbugger wants to merge 1 commit intoKludex:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When matching a mount point, record the
Mountas scope["route"]The purpose: when enriching logs with metadata, I would like to include the
nameof routes without having to re-traverse routes or rematch. Specifically, I'm focused on FastAPI endpoints andStaticFilesright now.For fastapi endpoints, this is already easy:

But for handling
StaticFilesmounts, this was the least intrusive way I could think to do it.I'm open to other thoughts, especially if Mount is used more widely internally in a way that would make this a bad idea.
Checklist