Fix CI error and clippy warning

KmolYuan · Aug 24, 2024 · 51a85f8 · 51a85f8
1 parent 8f223aa
commit 51a85f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/gh-deploy.yaml b/.github/workflows/gh-deploy.yaml
@@ -1,8 +1,8 @@
 name: Github Deploy
 on:
   push:
-    branches: [ main ]
-    tags: [ v* ]
+    branches: [main]
+    tags: [v*]
 jobs:
   cargo-publish:
     if: startsWith(github.ref, 'refs/tags/v')
@@ -18,6 +18,7 @@ jobs:
           cargo publish -p four-bar-ui || true
   gh-test-release:
     strategy:
+      fail-fast: false
       matrix:
         include:
           - os: ubuntu-latest

diff --git a/four-bar-ui/src/cli.rs b/four-bar-ui/src/cli.rs
@@ -45,6 +45,7 @@ impl Entry {
 }
 
 fn native(files: Vec<PathBuf>) {
+    // Safety: Free console window at the beginning is safe
     #[cfg(all(windows, feature = "native-win-release"))]
     unsafe {
         winapi::um::wincon::FreeConsole();