start stubbing out some docs for extents and templates

KodrAus · Mar 15, 2024 · 0b23c37 · 0b23c37
1 parent 21055e1
commit 0b23c37
Show file tree

Hide file tree

Showing 13 changed files with 315 additions and 36 deletions.
diff --git a/batcher/src/internal_metrics.rs b/batcher/src/internal_metrics.rs
@@ -27,7 +27,7 @@ impl Counter {
 }
 
 impl InternalMetrics {
-    pub fn sample(&self) -> impl Iterator<Item = emit::metrics::Metric<'static>> + 'static {
+    pub fn sample(&self) -> impl Iterator<Item = emit::metrics::Metric<'static, emit::empty::Empty>> + 'static {
         let InternalMetrics {
             queue_overflow,
             queue_batch_processed,
@@ -38,29 +38,44 @@ impl InternalMetrics {
 
         [
             emit::metrics::Metric::new(
+                "emit_batcher",
+                emit::empty::Empty,
                 stringify!(queue_overflow),
                 emit::well_known::METRIC_AGG_COUNT,
                 queue_overflow.sample(),
+                emit::empty::Empty,
             ),
             emit::metrics::Metric::new(
+                "emit_batcher",
+                emit::empty::Empty,
                 stringify!(queue_batch_processed),
                 emit::well_known::METRIC_AGG_COUNT,
                 queue_batch_processed.sample(),
+                emit::empty::Empty,
             ),
             emit::metrics::Metric::new(
+                "emit_batcher",
+                emit::empty::Empty,
                 stringify!(queue_batch_failed),
                 emit::well_known::METRIC_AGG_COUNT,
                 queue_batch_failed.sample(),
+                emit::empty::Empty,
             ),
             emit::metrics::Metric::new(
+                "emit_batcher",
+                emit::empty::Empty,
                 stringify!(queue_batch_panicked),
                 emit::well_known::METRIC_AGG_COUNT,
                 queue_batch_panicked.sample(),
+                emit::empty::Empty,
             ),
             emit::metrics::Metric::new(
+                "emit_batcher",
+                emit::empty::Empty,
                 stringify!(queue_batch_retry),
                 emit::well_known::METRIC_AGG_COUNT,
                 queue_batch_retry.sample(),
+                emit::empty::Empty,
             ),
         ]
         .into_iter()

diff --git a/batcher/src/lib.rs b/batcher/src/lib.rs
@@ -149,7 +149,7 @@ impl<T: Channel> Sender<T> {
         }
     }
 
-    pub fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static>> + 'static {
+    pub fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static, emit::empty::Empty>> + 'static {
         self.shared.sample_metrics()
     }
 }
@@ -350,7 +350,7 @@ impl<T: Channel> Receiver<T> {
         }
     }
 
-    pub fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static>> + 'static {
+    pub fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static, emit::empty::Empty>> + 'static {
         self.shared.sample_metrics()
     }
 }
@@ -434,13 +434,16 @@ struct Shared<T> {
 }
 
 impl<T: Channel> Shared<T> {
-    fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static>> + 'static {
+    fn sample_metrics(&self) -> impl Iterator<Item = emit::metrics::Metric<'static, emit::empty::Empty>> + 'static {
         let queue_length = { self.state.lock().unwrap().next_batch.channel.remaining() };
 
         self.metrics.sample().chain(Some(emit::metrics::Metric::new(
+            "emit_batcher",
+            emit::empty::Empty,
             "queue_length",
             emit::well_known::METRIC_AGG_LAST,
             queue_length,
+            emit::empty::Empty,
         )))
     }
 }

diff --git a/core/src/event.rs b/core/src/event.rs
@@ -40,10 +40,20 @@ impl<'a, P> Event<'a, P> {
         &self.module
     }
 
+    pub fn with_module(mut self, module: impl Into<Path<'a>>) -> Self {
+        self.module = module.into();
+        self
+    }
+
     pub fn extent(&self) -> Option<&Extent> {
         self.extent.as_ref()
     }
 
+    pub fn with_extent(mut self, extent: impl ToExtent) -> Self {
+        self.extent = extent.to_extent();
+        self
+    }
+
     pub fn ts(&self) -> Option<&Timestamp> {
         self.extent.as_ref().map(|extent| extent.as_point())
     }
@@ -59,9 +69,18 @@ impl<'a, P> Event<'a, P> {
         &self.tpl
     }
 
+    pub fn with_tpl(mut self, tpl: impl Into<Template<'a>>) -> Self {
+        self.tpl = tpl.into();
+        self
+    }
+
     pub fn props(&self) -> &P {
         &self.props
     }
+
+    pub fn with_props<U>(self, props: U) -> Event<'a, U> {
+        Event { module: self.module, extent: self.extent, tpl: self.tpl, props }
+    }
 }
 
 impl<'a, P: Props> Event<'a, P> {

diff --git a/core/src/filter.rs b/core/src/filter.rs
@@ -30,7 +30,7 @@ pub trait Filter {
         }
     }
 
-    fn wrap<E>(self, emitter: E) -> Wrap<Self, E>
+    fn wrap_emitter<E>(self, emitter: E) -> Wrap<Self, E>
     where
         Self: Sized,
     {
@@ -109,7 +109,7 @@ impl<F: Filter, E: Emitter> Emitter for Wrap<F, E> {
 }
 
 pub fn wrap<F: Filter, E: Emitter>(filter: F, emitter: E) -> Wrap<F, E> {
-    filter.wrap(emitter)
+    filter.wrap_emitter(emitter)
 }
 
 pub struct And<T, U> {