some better span names

KodrAus · Apr 10, 2024 · 8cdffa4 · 8cdffa4
1 parent 5bc0b53
commit 8cdffa4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/targets/file/src/lib.rs b/targets/file/src/lib.rs
@@ -384,7 +384,7 @@ impl Worker {
         }
     }
 
-    #[emit::span(rt: emit::runtime::internal(), arg: span, "on_batch")]
+    #[emit::span(rt: emit::runtime::internal(), arg: span, "write file batch")]
     fn on_batch(&mut self, mut batch: EventBatch) -> Result<(), BatchError<EventBatch>> {
         let now = std::time::UNIX_EPOCH.elapsed().unwrap();
         let ts = emit::Timestamp::new(now).unwrap();

diff --git a/targets/otlp/src/client.rs b/targets/otlp/src/client.rs
@@ -847,7 +847,7 @@ enum OtlpTransport<R> {
 }
 
 impl<R: data::RequestEncoder> OtlpTransport<R> {
-    #[emit::span(rt: emit::runtime::internal(), arg: span, "send")]
+    #[emit::span(rt: emit::runtime::internal(), arg: span, "send OTLP batch of {batch_size} events", batch_size: batch.len())]
     pub(crate) async fn send(
         &self,
         batch: Vec<PreEncoded>,

diff --git a/tests/smoke-test/main.rs b/tests/smoke-test/main.rs
@@ -69,6 +69,7 @@ async fn main() {
     emit::emit!(
         extent: timer,
         "{metric_agg} of {metric_name} is {metric_value}",
+        event_kind: "metric",
         metric_agg: "count",
         metric_name: "smoke_test::sum",
         #[emit::as_value]