feat(walletconnect): walletconnect integration #2223
Conversation
| Some(value) => Some(serde_json::from_value(value)?), | ||
| None => None, | ||
| }; | ||
| let (topic, url) = self.pairing.create(self.metadata.clone(), None)?; |
There was a problem hiding this comment.
i think then we should clean up these old pairings.
| /// Information about the controlling party (typically a wallet). | ||
| pub controller: Controller, | ||
| /// Information about the proposing party (typically a dApp). | ||
| pub proposer: Proposer, |
There was a problem hiding this comment.
I mean the other one is always Default::default() so an enum makes sense here then we can store only one of them.
| session.relay = settle.relay; | ||
| session.expiry = settle.expiry; | ||
|
|
||
| if let Some(value) = settle.session_properties { |
There was a problem hiding this comment.
do you mean we want to be able to discard this field if we were not able to deserialize it?
i think then the serde_json::from_str::<SessionProperties>(&value.to_string())? should be optional, i.e. we shouldn't fail (?) the whole function if we fail deserializing the arbitrary value.
p.s. we can also use serde_json::from_value instead of from_str and ditch .to_string()
| let topic = session.topic.clone(); | ||
| let pairing_topic = session.pairing_topic.clone(); | ||
| debug!("[{topic}] Session found! activating"); | ||
| self.session_manager.add_session(session); |
There was a problem hiding this comment.
why don't we add their pairings?
There was a problem hiding this comment.
no use for storing pairings as they're only needed to activate a session and then we'll move to using session for all communication. albeit I still consider extending pairing storage just like session storage but there's not any use for it right now.
| { | ||
| ctx.pairing.activate(topic)?; | ||
| } |
There was a problem hiding this comment.
the extra scope not needed.
also this always returns error (check KomodoPlatform/WalletConnectRust#3 (comment))
| let irn_metadata = param.irn_metadata(); | ||
| let ttl = irn_metadata.ttl; |
There was a problem hiding this comment.
we can use a timed/expirable map for this case. we do that for electrum and eth also i think. this is to avoid network-induced memory leaks.
There was a problem hiding this comment.
i mainly went over some of old comments and resolved the ones which i can see have been updated (could use a helping hand in the remaining ones by pointing where the updates are).
my estimation right now is i would need one more all-over iteration for approval (+ old comments), but i don't wanna promise since break my promises :D
Thanks for that huge work!
| session.relay = settle.relay; | ||
| session.expiry = settle.expiry; | ||
|
|
||
| if let Some(value) = settle.session_properties { |
There was a problem hiding this comment.
so,
- if
session_propertiesisn't sent, it's fine since it's optional, - if
session_propertiesis sent along in the request, we MUST succeed in parsing it (that means we must have an enumration of all the possible shapes it could be)- if we fail to de-serialize
session_propertieswe will fail the request (the MUST part).
- if we fail to de-serialize
why do we need it as Option<Value> (instead of Option<SessionProperties>) if we will fail the request if we fail to deserialize it?
|
|
||
| self.validate_chain_id(&session, chain_id)?; | ||
|
|
||
| // TODO: uncomment when WalletConnect wallets start listening to chainChanged event |
There was a problem hiding this comment.
So nothing happens(I mean wallets don't listen to this event) if we send such request
so what about just sending it for now and when wallets listen to it later we get this feat for free
Two reasons I didn't want to, this will add extra latency and corresponding wallet will return error as they don't recognize such session request |
#1543
This PR introduces the integration of WalletConnect into the Komodo DeFi Framework (KDF), enabling secure wallet connections for Cosmos and EVM-based chains. KDF acts as the DApp(in this PR), allowing users to initiate and manage transactions securely with external wallets e.g via Metamask.
Key changes include:
TendermintandEVM.TendermintandEVMhttps://specs.walletconnect.com/2.0/specs/clients/sign/
https://specs.walletconnect.com/2.0/specs/clients/core/pairing/
https://specs.walletconnect.com/2.0/specs/clients/core/crypto/
https://specs.walletconnect.com/2.0/specs/servers/relay/
https://docs.reown.com/advanced/multichain/rpc-reference/ethereum-rpc
Additional improvements include cleanup of unused dependencies, minor code refinements, and WASM compatibility
Updated deps:
Added deps:
Removed deps:
How to test using EVM coin e.g
ETH(Native && WASM)cargo run){ "method": "wc_new_connection", "userpass": "{{ _.userpass }}", "mmrpc": "2.0", "params": { "required_namespaces": { "eip155": { "chains": ["eip155:1"], "methods": [ "eth_sendTransaction", "eth_signTransaction", "personal_sign" ], "events": [ "accountsChanged", "chainChanged" ] } } } }ETHcoin (set"priv_key_policy": "WalletConnect",in activation params).Note: To add more
eip155chains, modify the chains array like this:["eip155:1", "eip155:250"]