chore(ctx): replace gstuff constructible with oncelock #2267

borngraced · 2024-11-06T23:40:17Z

Replaced Constructible from the gstuff crate with once_cell::sync::OnceCell for managing lazy-initialized values in mm_ctx for better performance and stronger thread safety.

also add a slight improvement to from_ctx

onur-ozkan · 2024-11-07T07:06:42Z

mm2src/mm2_core/src/mm_ctx.rs

 use lazy_static::lazy_static;
 use libp2p::PeerId;
 use mm2_event_stream::{controller::Controller, Event, EventStreamConfiguration};
 use mm2_metrics::{MetricsArc, MetricsOps};
+use once_cell::sync::OnceCell;


Why not OnceLock from the standard library?

ah thanks!, I promise, I didn't know this is stable already..also I've had OnceCell on my mind for a long time.

mm2src/mm2_core/src/mm_ctx.rs

mariocynicys

One comment inline, LGTM otherwise :)

mm2src/coins/z_coin/storage/blockdb/blockdb_sql_storage.rs

mariocynicys

non-blockers.
LGTM :)

mm2src/coins/z_coin/storage/blockdb/blockdb_sql_storage.rs

shamardy

LGTM!

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (KomodoPlatform#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (KomodoPlatform#2283) feat(tendermint): validators RPC (KomodoPlatform#2310) chore(CI): validate Cargo lock file (KomodoPlatform#2309) test(P2P): add test for peer time sync validation (KomodoPlatform#2304) fix mm2_p2p dev build (KomodoPlatform#2311) update Cargo.lock (KomodoPlatform#2308) chore(CI): unlock wasm-pack version (KomodoPlatform#2307) add `wasm` feature on WASM for timed-map (KomodoPlatform#2306) replace broken rpc link (KomodoPlatform#2305) chore(eth-websocket): remove some unnecessary wrappers (KomodoPlatform#2291) improvement(CI): switch to proper rust caching (KomodoPlatform#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (KomodoPlatform#2295) chore(ci): Update docker build for wasm (KomodoPlatform#2294) chore(p2p): follow-up nits (KomodoPlatform#2302) feat(p2p): ensure time synchronization in the network (KomodoPlatform#2255) bump libp2p (KomodoPlatform#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (KomodoPlatform#2290) chore(ctx): replace gstuff constructible with oncelock (KomodoPlatform#2267) don't rely on core (KomodoPlatform#2289) ...

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

This reverts commit ac926dd

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

This reverts commit ac926dd

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

This reverts commit ac926dd

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

This reverts commit ac926dd

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

borngraced added 2 commits November 6, 2024 23:50

improve mm_ctx perf

098989e

uncommit mm2_test_helper lock file

c9baf0d

borngraced added the in progress label Nov 6, 2024

borngraced self-assigned this Nov 6, 2024

onur-ozkan reviewed Nov 7, 2024

View reviewed changes

use OnceLock from std

a7ec9c5

mariocynicys reviewed Nov 7, 2024

View reviewed changes

mm2src/mm2_core/src/mm_ctx.rs Show resolved Hide resolved

mm2src/mm2_core/src/mm_ctx.rs Outdated Show resolved Hide resolved

undo try_lock

2fbcd3f

borngraced changed the title ~~chore(ctx): replace gstuff constructible with once_cell~~ chore(ctx): replace gstuff constructible with oncelock Nov 8, 2024

nits

d96e447

borngraced added under review and removed in progress labels Nov 19, 2024

shamardy added the 2.3.0-beta label Nov 25, 2024

mariocynicys previously approved these changes Dec 9, 2024

View reviewed changes

mm2src/coins/z_coin/storage/blockdb/blockdb_sql_storage.rs Outdated Show resolved Hide resolved

avoid redundant clone of arc and replace AtomicDex API with KDF

72018af

borngraced dismissed mariocynicys’s stale review via 72018af December 9, 2024 15:12

mariocynicys previously approved these changes Dec 9, 2024

View reviewed changes

mm2src/coins/z_coin/storage/blockdb/blockdb_sql_storage.rs Show resolved Hide resolved

mm2src/coins/z_coin/storage/blockdb/blockdb_sql_storage.rs Show resolved Hide resolved

borngraced dismissed mariocynicys’s stale review via ad5dc59 December 9, 2024 15:43

borngraced force-pushed the improve-mm_ctx branch from ad5dc59 to 72018af Compare December 9, 2024 16:19

mariocynicys approved these changes Dec 9, 2024

View reviewed changes

shamardy approved these changes Dec 10, 2024

View reviewed changes

shamardy merged commit ac926dd into dev Dec 10, 2024
35 of 46 checks passed

shamardy deleted the improve-mm_ctx branch December 10, 2024 17:59

onur-ozkan mentioned this pull request Dec 18, 2024

chore(release): v2.3.0-beta #2284

Merged

shamardy added a commit that referenced this pull request Jan 30, 2025

Revert "chore(ctx): replace gstuff constructible with oncelock (#2267)"

33eb336

This reverts commit ac926dd

shamardy added a commit that referenced this pull request Jan 30, 2025

Revert "chore(ctx): replace gstuff constructible with oncelock (#2267)"

a6e458d

This reverts commit ac926dd

shamardy added a commit that referenced this pull request Jan 30, 2025

Revert "chore(ctx): replace gstuff constructible with oncelock (#2267)"

add37ea

This reverts commit ac926dd

shamardy added a commit that referenced this pull request Jan 30, 2025

Revert "chore(ctx): replace gstuff constructible with oncelock (#2267)"

ea816ce

This reverts commit ac926dd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ctx): replace gstuff constructible with oncelock #2267

chore(ctx): replace gstuff constructible with oncelock #2267

borngraced commented Nov 6, 2024 •

edited

Loading

onur-ozkan Nov 7, 2024

borngraced Nov 7, 2024 •

edited

Loading

mariocynicys left a comment

mariocynicys left a comment

shamardy left a comment

chore(ctx): replace gstuff constructible with oncelock #2267

chore(ctx): replace gstuff constructible with oncelock #2267

Conversation

borngraced commented Nov 6, 2024 • edited Loading

onur-ozkan Nov 7, 2024

Choose a reason for hiding this comment

borngraced Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

mariocynicys left a comment

Choose a reason for hiding this comment

mariocynicys left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

borngraced commented Nov 6, 2024 •

edited

Loading

borngraced Nov 7, 2024 •

edited

Loading