chore(libp2p): k-0.52.11 bump #2296

onur-ozkan · 2024-12-17T10:32:35Z

Bumps libp2p to include KomodoPlatform/rust-libp2p@f949f65 for security reasons.

Fixes #771

laruh · 2024-12-17T16:52:14Z

I suggest next time we first review the PR in the repository we use as a dependency, and only after it is approved, review the PR in KDF that updates the dependency version. Otherwise, its hard to track code changes, especially if force push was used.

laruh · 2024-12-17T16:55:31Z

For the history, could you clarify why we dont need to check and remove topics with empty peers here?
KomodoPlatform/rust-libp2p@15b30da#diff-368386d6c30a7eb4d60fcddda689bba01e9e215451a387fa58ff93b12fb914deR2071

onur-ozkan · 2024-12-17T18:02:45Z

I suggest next time we first review the PR in the repository we use as a dependency, and only after it is approved, review the PR in KDF that updates the dependency version. Otherwise, its hard to track code changes, especially if force push was used.

Sure, this is the first time our team decided to make review on libp2p changes, so I didn't know you guys wanted to make review on that.

For the history, could you clarify why we dont need to check and remove topics with empty peers here? KomodoPlatform/rust-libp2p@15b30da#diff-368386d6c30a7eb4d60fcddda689bba01e9e215451a387fa58ff93b12fb914deR2071

No big reason. @mariocynicys said doing that on disconnection should be enough and I didn't wanted to argue as it's not worth to discuss over that. Both are fine IMO.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

laruh

Thank you for the fix! LGTM!

laruh · 2024-12-18T06:44:00Z

@mariocynicys if you think there are more places of improvements, I suggest you to open PR in https://github.com/KomodoPlatform/rust-libp2p/tree/debugging

mariocynicys · 2024-12-18T08:21:46Z

what if two seed peers are connected to each other? they will never delete the topic, no?

@onur-ozkan does the libp2p fix cover this case?

onur-ozkan · 2024-12-18T08:38:18Z

Why would they delete topics if they are connected to each other?

mariocynicys · 2024-12-18T08:51:37Z

in light of the original issue: #771
maker - seed1 - seed2 - taker let's say this is how the messages for some swap are propagated, you can also replace seed1 - seed2 by any number of seeds in any configuration (not just a line): maker - p2p - taker.

if the maker and taker finish the swap and unsubscribe from it, doesn't this still leave us with intermediate nodes still subscribing?

onur-ozkan · 2024-12-18T09:07:23Z

No it does not. Seed nodes do not subscribe/unsubscribe to topics. In your scenario seed nodes would only have maker and taker on the topic records without including the seed nodes.

mariocynicys · 2024-12-18T09:15:41Z

aha clear thanks

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (KomodoPlatform#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (KomodoPlatform#2283) feat(tendermint): validators RPC (KomodoPlatform#2310) chore(CI): validate Cargo lock file (KomodoPlatform#2309) test(P2P): add test for peer time sync validation (KomodoPlatform#2304) fix mm2_p2p dev build (KomodoPlatform#2311) update Cargo.lock (KomodoPlatform#2308) chore(CI): unlock wasm-pack version (KomodoPlatform#2307) add `wasm` feature on WASM for timed-map (KomodoPlatform#2306) replace broken rpc link (KomodoPlatform#2305) chore(eth-websocket): remove some unnecessary wrappers (KomodoPlatform#2291) improvement(CI): switch to proper rust caching (KomodoPlatform#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (KomodoPlatform#2295) chore(ci): Update docker build for wasm (KomodoPlatform#2294) chore(p2p): follow-up nits (KomodoPlatform#2302) feat(p2p): ensure time synchronization in the network (KomodoPlatform#2255) bump libp2p (KomodoPlatform#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (KomodoPlatform#2290) chore(ctx): replace gstuff constructible with oncelock (KomodoPlatform#2267) don't rely on core (KomodoPlatform#2289) ...

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

This reverts commit fe5a274

* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>

onur-ozkan added improvement: resource usage Improvements made on resource usage on runtime or/and compile time improvement: security Improvements made on runtime security status: pending review priority: urgent Critical tasks requiring immediate action. labels Dec 17, 2024

onur-ozkan mentioned this pull request Dec 17, 2024

chore(release): v2.3.0-beta #2284

Merged

onur-ozkan force-pushed the libp2p-bump branch from 5fd6342 to 51154b0 Compare December 17, 2024 12:43

onur-ozkan changed the title ~~chore(libp2p): k-0.52.5 bump~~ chore(libp2p): k-0.52.7 bump Dec 17, 2024

onur-ozkan changed the title ~~chore(libp2p): k-0.52.7 bump~~ chore(libp2p): k-0.52.8 bump Dec 17, 2024

onur-ozkan changed the title ~~chore(libp2p): k-0.52.8 bump~~ chore(libp2p): k-0.52.9 bump Dec 17, 2024

onur-ozkan force-pushed the libp2p-bump branch from 51154b0 to 66bd6f2 Compare December 17, 2024 13:25

onur-ozkan changed the title ~~chore(libp2p): k-0.52.9 bump~~ chore(libp2p): k-0.52.10 bump Dec 17, 2024

onur-ozkan force-pushed the libp2p-bump branch from 66bd6f2 to 9fe01c2 Compare December 17, 2024 15:57

bump libp2p

7907b83

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the libp2p-bump branch from 9fe01c2 to 7907b83 Compare December 18, 2024 03:48

onur-ozkan changed the title ~~chore(libp2p): k-0.52.10 bump~~ chore(libp2p): k-0.52.11 bump Dec 18, 2024

laruh approved these changes Dec 18, 2024

View reviewed changes

onur-ozkan merged commit fe5a274 into dev Dec 18, 2024
16 of 25 checks passed

onur-ozkan deleted the libp2p-bump branch December 18, 2024 06:33

shamardy added a commit that referenced this pull request Jan 30, 2025

Revert "bump libp2p (#2296)"

28ebe38

This reverts commit fe5a274

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(libp2p): k-0.52.11 bump #2296

chore(libp2p): k-0.52.11 bump #2296

Uh oh!

onur-ozkan commented Dec 17, 2024 •

edited

Loading

Uh oh!

laruh commented Dec 17, 2024

Uh oh!

laruh commented Dec 17, 2024 •

edited

Loading

Uh oh!

onur-ozkan commented Dec 17, 2024

Uh oh!

laruh left a comment

Uh oh!

Uh oh!

laruh commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024

Uh oh!

onur-ozkan commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024 •

edited

Loading

Uh oh!

onur-ozkan commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024

Uh oh!

Uh oh!

chore(libp2p): k-0.52.11 bump #2296

chore(libp2p): k-0.52.11 bump #2296

Uh oh!

Conversation

onur-ozkan commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laruh commented Dec 17, 2024

Uh oh!

laruh commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan commented Dec 17, 2024

Uh oh!

laruh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laruh commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024

Uh oh!

onur-ozkan commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan commented Dec 18, 2024

Uh oh!

mariocynicys commented Dec 18, 2024

Uh oh!

Uh oh!

onur-ozkan commented Dec 17, 2024 •

edited

Loading

laruh commented Dec 17, 2024 •

edited

Loading

mariocynicys commented Dec 18, 2024 •

edited

Loading