Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tendermint): staking/delegation #2322

Merged
merged 13 commits into from
Jan 27, 2025
Merged

feat(tendermint): staking/delegation #2322

merged 13 commits into from
Jan 27, 2025

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Jan 15, 2025 •
edited
Loading

Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.

Next is to do the same for undelegation on remove_delegation.

TODO: File a documentation issue on https://github.com/KomodoPlatform/komodo-docs-mdx

@onur-ozkan
P.o.C implementation of cosmos delegation
36c5001 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
improve delegate implementation significantly
037a9dd 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan changed the title feat(tendermint): delegate/undelegate RPCs feat(tendermint): staking/delegation Jan 15, 2025
@onur-ozkan
consolidate QTUM and Cosmos staking
4012550 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch from 081df90 to 4012550 Compare January 15, 2025 14:46
@onur-ozkan
remove coin field from DelegatePayload
c99ca55 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
minor readibility improvements
d2a6111 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
support delegate transactions in tx_history
15948b0 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
warn on unrecognized events
c42fc6e 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
rename pk to priv_key
6e5e145 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch 4 times, most recently from 8145b90 to 16dad85 Compare January 16, 2025 10:20
@onur-ozkan
add docker test
1dd2b73 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch 2 times, most recently from f67185a to 1dd2b73 Compare January 16, 2025 10:47
@onur-ozkan
improve amount calculation slightly
0f08e05 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch from 4340e37 to 0f08e05 Compare January 20, 2025 10:07
@onur-ozkan onur-ozkan marked this pull request as ready for review January 20, 2025 10:07
laruh
laruh requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! code is very clean, I have small notes

mm2src/coins/tendermint/tendermint_coin.rs Show resolved Hide resolved
mm2src/coins/tendermint/tendermint_coin.rs Outdated Show resolved Hide resolved
@shamardy shamardy self-requested a review January 23, 2025 12:06
shamardy
shamardy previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean and easy to review PR! Only one non-blocker.

mm2src/coins/rpc_command/tendermint/staking.rs Show resolved Hide resolved
@onur-ozkan
create helper closure for balance error
8d44f10 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
laruh
laruh previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

borngraced
borngraced requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work...one not directly related note

mm2src/coins/tendermint/tendermint_token.rs Outdated Show resolved Hide resolved
@onur-ozkan
use io::Error
a08dbcb 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
use memo by ref
e3d4c8c 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

All notes are resolved.

shamardy
shamardy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit 73e0650 into dev Jan 27, 2025
19 of 24 checks passed
@shamardy shamardy deleted the tendermint-delegation branch January 27, 2025 09:53
shamardy pushed a commit that referenced this pull request Jan 28, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
a5254d6 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
shamardy pushed a commit that referenced this pull request Jan 30, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
b253d19 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
shamardy pushed a commit that referenced this pull request Jan 30, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
59154bd 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimxy dimxy dimxy left review comments

@borngraced borngraced borngraced requested changes

@shamardy shamardy shamardy approved these changes

@laruh laruh laruh left review comments

Assignees
No one assigned
Labels
feature: protocol feature: RPC status: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @dimxy @shamardy @borngraced @laruh