feat(tendermint): unstaking/undelegation #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
changed the title
onur-ozkan
commented
Jan 30, 2025
onur-ozkan
commented
Jan 30, 2025
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
cosmos-unstake
branch
from
525c015 to
7f5f68a
Compare
borngraced
requested changes
Feb 3, 2025
Signed-off-by: onur-ozkan <work@onurozkan.dev>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dimxy
reviewed
Feb 6, 2025
dimxy
reviewed
Feb 6, 2025
| @@ -38,6 +38,7 @@ const IBC_SEND_EVENT: &str = "ibc_transfer"; | |||
| const IBC_RECEIVE_EVENT: &str = "fungible_token_packet"; | |||
| const IBC_NFT_RECEIVE_EVENT: &str = "non_fungible_token_packet"; | |||
| const DELEGATE_EVENT: &str = "delegate"; | |||
| const UNDELEGATE_EVENT: &str = "unbond"; | |||
There was a problem hiding this comment.
Isn't this a typo by a chance (not 'unbound')?
|
@onur-ozkan please open docs issue for this change. |
shamardy
approved these changes
Feb 7, 2025
Comment on lines
+4882
to
+4886
| if req.withdraw_from.is_some() { | ||
| return MmError::err(DelegationError::InvalidPayload { | ||
| reason: "Can't use `withdraw_from` field on 'remove_delegation' RPC for Cosmos.".to_owned(), | ||
| }); | ||
| } |
There was a problem hiding this comment.
Non blocker but for docs and maybe future implementations. We should support HD wallet for all delegate/undelegate/etc.. operations. For now such mention in docs that this is done for the enabled address only.
shamardy
pushed a commit
that referenced
this pull request
Feb 7, 2025
Adds tendermint protocol support on remove_delegation RPC, and extends tendermint transaction history implementation to support undelegate transactions.
I will once we consider whole staking functionality is implemented. I didn't do this yet as things can change a little bit while implementing remaining parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tendermint protocol support on
remove_delegationRPC, and extends tendermint transaction history implementation to support undelegate transactions.Next is to add staking listing RPCs for delegations, undelegations (with claiming period informations), rewards, etc.