-
Notifications
You must be signed in to change notification settings - Fork 3
feat(pubkeys): add list banned pubkeys method #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new RPC method list_banned_pubkeys
to retrieve currently banned pubkeys. The implementation follows existing patterns in the codebase by adding request/response classes, wiring the method into the wallet namespace, and exposing it through the SDK's PubkeyManager.
- Adds
ListBannedPubkeysRequest
andListBannedPubkeysResponse
classes with a newBannedPubkeyDetails
model - Exposes the new method through the wallet RPC namespace and PubkeyManager
- Exports new types for external SDK consumers
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/komodo_defi_types/lib/src/exported_rpc_types.dart | Exports new BannedPubkeyDetails type for SDK consumers |
packages/komodo_defi_sdk/lib/src/pubkeys/pubkey_manager.dart | Adds listBannedPubkeys() method to PubkeyManager |
packages/komodo_defi_rpc_methods/lib/src/rpc_methods_library.dart | Wires new RPC method into WalletMethods namespace |
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/wallet/list_banned_pubkeys.dart | Implements request/response classes and BannedPubkeyDetails model |
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/rpc_methods.dart | Exports the new list_banned_pubkeys module |
class ListBannedPubkeysRequest | ||
extends BaseRequest<ListBannedPubkeysResponse, GeneralErrorResponse> { | ||
ListBannedPubkeysRequest({required String rpcPass}) | ||
: super(method: 'list_banned_pubkeys', rpcPass: rpcPass, mmrpc: null); |
Copilot
AI
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing null
explicitly for the mmrpc
parameter is unnecessary and could be confusing. Consider omitting this parameter if it's optional or using a more explicit default value.
: super(method: 'list_banned_pubkeys', rpcPass: rpcPass, mmrpc: null); | |
: super(method: 'list_banned_pubkeys', rpcPass: rpcPass); |
Copilot uses AI. Check for mistakes.
Visit the preview URL for this PR (updated for commit 6f9455b): https://komodo-defi-sdk--pr162-codex-implement-list-dwhw5d4r.web.app (expires Tue, 05 Aug 2025 16:54:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347 |
Summary
list_banned_pubkeys
request and responsePubkeyManager
for listing banned pubkeysTesting
flutter analyze
(fails: CounterView etc. undefined)https://chatgpt.com/codex/tasks/task_e_6888ea5146c083269349581dde786782