Skip to content

Conversation

CharlVS
Copy link
Member

@CharlVS CharlVS commented Oct 5, 2025

Summary

This PR adds autocomplete functionality to the MnemonicValidator class to support an enhanced UI for the login flow.

Changes

  • Added method: Returns BIP39 words that start with a given prefix, useful for implementing autocomplete when users enter their seed phrases word by word
  • Added method: Provides access to all valid BIP39 words for custom autocomplete implementations
  • Code formatting improvements: Enhanced readability of binary string conversion
  • Updated bundled coins repo commit: Updated to latest commit hash

Usage Example

final validator = MnemonicValidator();
await validator.init();
final matches = validator.getAutocompleteMatches('aba');
// Returns: {'abandon', 'ability', 'about'}

Related

This change supports the UI login flow implementation in the main wallet repository.


Note

Adds autocomplete methods to MnemonicValidator for BIP39 word suggestions and exposes all words; minor formatting cleanup.

  • Utils: MnemonicValidator
    • Autocomplete: Add getAutocompleteMatches(prefix, {maxResults = 10}) to return matching BIP39 words (case-insensitive), with initialization assert.
    • Wordlist Access: Add getAllWords() to return all valid BIP39 words, with initialization assert.
    • Minor: Reformat binary string construction for readability.

Written by Cursor Bugbot for commit a0bedc5. This will update automatically on new commits. Configure here.

- Updated branch from main to hotfix-remove-memorydb-size-metric
- Updated commit hash to 476262f0d3390e24cfe672d5e15a78a46397dbfa
- Updated checksums for all platform binaries (web, ios, macos, windows, android-armv7, android-aarch64, linux)
- Add getAutocompleteMatches() method to MnemonicValidator for prefix-based word suggestions
- Add getAllWords() method to retrieve all valid BIP39 words
- Update bundled coins repo commit hash
- Improve code formatting in binary string conversion

These changes support implementing an enhanced UI for the login flow with autocomplete functionality when users enter their seed phrases.
Copy link

coderabbitai bot commented Oct 5, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add/ui-login-flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS changed the base branch from main to dev October 5, 2025 14:01
…d/ui-login-flow

# Conflicts:
#	packages/komodo_defi_framework/app_build/build_config.json
Copy link
Contributor

github-actions bot commented Oct 5, 2025

Visit the preview URL for this PR (updated for commit a0bedc5):

https://komodo-playground--pr235-add-ui-login-flow-lzw4noom.web.app

(expires Tue, 14 Oct 2025 15:40:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Visit the preview URL for this PR (updated for commit a0bedc5):

https://kdf-sdk--pr235-add-ui-login-flow-bhjj4zmp.web.app

(expires Tue, 14 Oct 2025 15:40:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d

break;
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unpredictable Autocomplete Suggestions Due to Set Iteration

The getAutocompleteMatches method uses Sets for both its source wordlist and collected results. Since Set iteration order isn't guaranteed, hitting maxResults can lead to inconsistent autocomplete suggestions (different words or orders) for the same prefix across runs, creating an unpredictable user experience.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant