-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add autocomplete support for mnemonic seed phrase input #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Updated branch from main to hotfix-remove-memorydb-size-metric - Updated commit hash to 476262f0d3390e24cfe672d5e15a78a46397dbfa - Updated checksums for all platform binaries (web, ios, macos, windows, android-armv7, android-aarch64, linux)
- Add getAutocompleteMatches() method to MnemonicValidator for prefix-based word suggestions - Add getAllWords() method to retrieve all valid BIP39 words - Update bundled coins repo commit hash - Improve code formatting in binary string conversion These changes support implementing an enhanced UI for the login flow with autocomplete functionality when users enter their seed phrases.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…d/ui-login-flow # Conflicts: # packages/komodo_defi_framework/app_build/build_config.json
Visit the preview URL for this PR (updated for commit a0bedc5): https://komodo-playground--pr235-add-ui-login-flow-lzw4noom.web.app (expires Tue, 14 Oct 2025 15:40:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
Visit the preview URL for this PR (updated for commit a0bedc5): https://kdf-sdk--pr235-add-ui-login-flow-bhjj4zmp.web.app (expires Tue, 14 Oct 2025 15:40:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
…dk-flutter into add/ui-login-flow
break; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unpredictable Autocomplete Suggestions Due to Set Iteration
The getAutocompleteMatches
method uses Set
s for both its source wordlist and collected results. Since Set
iteration order isn't guaranteed, hitting maxResults
can lead to inconsistent autocomplete suggestions (different words or orders) for the same prefix across runs, creating an unpredictable user experience.
Summary
This PR adds autocomplete functionality to the MnemonicValidator class to support an enhanced UI for the login flow.
Changes
Usage Example
Related
This change supports the UI login flow implementation in the main wallet repository.
Note
Adds autocomplete methods to
MnemonicValidator
for BIP39 word suggestions and exposes all words; minor formatting cleanup.MnemonicValidator
getAutocompleteMatches(prefix, {maxResults = 10})
to return matching BIP39 words (case-insensitive), with initialization assert.getAllWords()
to return all valid BIP39 words, with initialization assert.Written by Cursor Bugbot for commit a0bedc5. This will update automatically on new commits. Configure here.