-
Notifications
You must be signed in to change notification settings - Fork 4
fix: omit params for getEnabledCoins #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix: omit params for getEnabledCoins #93
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the issue with the get_enabled_coins
RPC by omitting the unnecessary params
from the request payload.
- Added an override for toJson() in GetEnabledCoinsRequest to remove
params
. - Included a temporary workaround comment with a reference to the related framework issue.
Comments suppressed due to low confidence (1)
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/activation/get_enabled_coins.dart:14
- Consider adding a TODO comment with reference to issue #2498 and an expected resolution timeline, so this workaround can be revisited and removed once the API bug is fixed.
// Temporary fix: omit the `params` key until API bug is resolved
Visit the preview URL for this PR (updated for commit 30e198e): https://komodo-defi-sdk--pr93-d0re2s-codex-remove-l49bknx7.web.app (expires Mon, 30 Jun 2025 15:37:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347 |
Summary
params
when calling the v2get_enabled_coins
RPCTesting
flutter analyze
(fails: 2406 issues)https://chatgpt.com/codex/tasks/task_e_68596de1ac108326b5fdde383156061b