-
-
Notifications
You must be signed in to change notification settings - Fork 55
Option for outputting as action IDs (CLI) #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One more thing: why always the CRP version of the action? Why not use the ID that corresponds to the job of the recipe? |
|
Also, what's the advantage of using the action id over the action name? Can't plugins match the action names? |
It's ultimately easier to use an ID (which applies to all game languages) than try to parse names. Plus, there are some other mods that completely changes the language to one not actually supported officially (a Russian text mod). It just saves headaches with compatibility and worrying about SE making a mess of strings, which they do from time to time.
It just serves as the base for all actions, as going from CRP to another job is as simple as adding its ClassJob row - 8 (CRP is row 8, BSM is row 9, so to get a BSM equivalent it's adding +1 (9 - 8)). Needing all the other job equivalents was a bit of extra bloating imo since it can be calculated if required (which is how I've handled it for Artisan). |
|
Patch 7.41 added "Stellar Steady Hand" which Raphael plans to support. The problem is that "Stellar Steady Hand" is a One solution would be to replace the current action IDs with stable strings or IDs that Raphael would define. This solves the issue of SE maybe breaking things by changing the action name as Raphael would be able to keep the names stable. What are your thoughts? Relevant PR: #307. |
The action is a static ID across all jobs (46843) and with my implementation in Artisan I only save the CRP versions of actions from the CLI output as Artisan macros aren't job specific. So would adding |
Works for me :) |
Adds each action's CRP version ID for the purposes of outputting as a list of IDs in the CLI for better compatibility across game languages (primarily for plugin usage).