Fix simulator and solver not allowing openers to be used after actions that do not increase step count #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying raphael-rs with
|
| Latest commit: |
944988d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d77f8433.raphael-rs.pages.dev |
| Branch Preview URL: | https://bug-opener-after-quick-innov.raphael-rs.pages.dev |
Owner
Author
|
Hardened Survey Plank Raphael v0.26.0: 11378 / 14900 Quality. Raphael v0.26.1: 11427 / 14900 Quality. |
Owner
Author
|
Hardened Survey Plank Raphael v0.26.0: 14934 / 14900 Quality, 21 steps, 54 seconds. Raphael v0.26.1: 15112 / 14900 Quality, 21 steps, 54 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312.
It is possible to use openers (e.g. Muscle Memory, Reflect) after actions that do not increase step count (e.g. Heart and Soul, Quick Innovation).
The current simulator and solver do not implement this, which means that the current generated macros may not be optimal when Quick Innovation is enabled due to the existence of the Quick Innovation > Reflect opening.
The solver being suboptimal is not just a theoretical problem, but can be observed in real use cases. See changes to the
hardened_survey_plank_5558_5216_heart_and_soul_quick_innovationtest.