Skip to content

Conversation

@KonaeAkira
Copy link
Owner

@KonaeAkira KonaeAkira commented Feb 5, 2026

Changes:

  • Use Ui::indent instead of implementing our own indent.
  • Move scroll reset logic to MultilineMonospace:
    • The scroll should reset whenever the text changes instead of only when the actions change.
    • Remove the old workaround of guessing the id of the ScrollArea and deleting its state.
  • Move macro-formatting logic to a single function that is more easily testable:
    fn create_macros(config: &MacroViewConfig, actions: &[Action]) -> Vec<String> {
      todo!();
    }
  • Write aforementioned tests.

@KonaeAkira KonaeAkira added enhancement A-gui Area: Graphical user interface labels Feb 5, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2026

Deploying raphael-rs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ccdd57
Status: ✅  Deploy successful!
Preview URL: https://96e7b0cf.raphael-rs.pages.dev
Branch Preview URL: https://feat-refactor-macro-widget.raphael-rs.pages.dev

View logs

@KonaeAkira KonaeAkira marked this pull request as ready for review February 6, 2026 22:20
@KonaeAkira KonaeAkira merged commit 15da738 into preview Feb 7, 2026
4 checks passed
@KonaeAkira KonaeAkira deleted the feat/refactor-macro-widget branch February 7, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-gui Area: Graphical user interface enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant