Support for Bitbucket Cloud and Server #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konamiman
requested changes
Feb 21, 2018
…to select the appropriate pattern. This adds support for Bitbucket Cloud and Server. Server type is guessed based on baseUrl, if not overriden. It will need to be overriden for custom domains or Bitbucket Server.
wrenoud
changed the title
Author
|
I updated the pull request to have a server type config option instead of exposing a url pattern. This allowed for customizing the line anchor format as well, and makes it easy to extend for any other hosted git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #5
I work with git hosted on Bitbucket Server so the default url pattern doesn't work for me, but a simple configurable substitution pattern gets me most of the way, see the readme edits.
The line # still doesn't work, some additional configuration would be needed for that