feat(kong): support configurable kgo deployment selector labels #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
szesch
force-pushed
the
configurable-operator-selector-labels
branch
from
f074617
to
7ef911a
Compare
pmalek
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Please bump the patch version in
charts/charts/gateway-operator/Chart.yaml
Lines 10 to 11 in 7f12944
This will cause a release straight away after merging.
szesch
force-pushed
the
configurable-operator-selector-labels
branch
from
13acf7d
to
7e4ccec
Compare
pmalek
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We are currently deploying KGO through kustomize and are trying to migrate to helm with zero downtime. One issue I've seen is that the deployment selector labels have changed. Since that is an immutable field it causes issues with the helm deploy of the gateway operator. This PR adds the ability to override the default selector labels.
Special notes for your reviewer:
Checklist
mainbranch.