Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Admins examples broken steps formatting #8073

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Admins examples broken steps formatting #8073

wants to merge 2 commits into from

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Oct 22, 2024 •
edited
Loading

Description

Fixing this step formatting issue:

Screenshot 2024-10-22 at 8 51 00 AM

Testing instructions

Preview link: https://deploy-preview-8073--kongdocs.netlify.app/gateway/latest/production/access-control/register-admin-api/

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 22, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner October 22, 2024 15:51
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 379b91a
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/671801c40829160008dfec27
😎 Deploy Preview https://deploy-preview-8073--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudjumpercat
cloudjumpercat requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting still looks off to me in the preview
Screenshot 2024-10-22 at 1 17 39 PM

@lena-larionova
Copy link
Contributor Author

@cloudjumpercat that's what I get for fixing this from the Github UI and not checking locally 😅 Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat Awaiting requested review from cloudjumpercat

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lena-larionova @cloudjumpercat