Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: bump version in e2e upgrade tests #838

Merged
merged 2 commits into from
Nov 4, 2024
Merged

tests: bump version in e2e upgrade tests #838

merged 2 commits into from
Nov 4, 2024

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Bumps the KGO version in the upgrade tests to the latest v1.4.0.

@czeslavo czeslavo self-assigned this Oct 31, 2024
@czeslavo czeslavo added this to the KGO v1.4.x milestone Oct 31, 2024
@czeslavo czeslavo marked this pull request as ready for review November 1, 2024 09:02
@czeslavo czeslavo requested a review from a team as a code owner November 1, 2024 09:02
pmalek
pmalek reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a test case for 1.3.0 to 1.4.0 as well?

Additionally while at it I believe we can remove the case for 1.2.0 to 1.2.3 migration at this point (to cut down the CI run time).

@czeslavo
Copy link
Contributor Author

czeslavo commented Nov 4, 2024

Can we please add a test case for 1.3.0 to 1.4.0 as well?

Additionally while at it I believe we can remove the case for 1.2.0 to 1.2.3 migration at this point (to cut down the CI run time).

I adjusted the test cases' names so they are generic enough to be valid at any point in time. I also reopened #121 to handle automatic version updates and will handle that in a next PR.

@czeslavo czeslavo requested a review from pmalek November 4, 2024 11:06
pmalek
pmalek reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're OK making the step towards making the testcases a bit more generic for the sake of small readability decrease.

BTW: tests seem to have failed 🤔

test/e2e/test_helm_install_upgrade.go Show resolved Hide resolved
@czeslavo czeslavo force-pushed the bump-e2e-tests branch 5 times, most recently from ca0535f to 15f3e47 Compare November 4, 2024 13:42
@czeslavo
Copy link
Contributor Author

czeslavo commented Nov 4, 2024

@pmalek I've fixed the failures - it turned out to be a wrong assertion requiring the DP image to be patched.

@czeslavo czeslavo requested a review from pmalek November 4, 2024 15:59
@pmalek pmalek enabled auto-merge (squash) November 4, 2024 16:06
@pmalek pmalek merged commit 4e75008 into main Nov 4, 2024
21 checks passed
@pmalek pmalek deleted the bump-e2e-tests branch November 4, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@czeslavo czeslavo

Labels
area/tests
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@czeslavo @pmalek