feat: Add disabling logic to mandate storage option by the API [INS-5159] #8548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavkout
force-pushed
the
feature/ins-5159
branch
3 times, most recently
from
c4f0d02 to
a9786a7
Compare
pavkout
force-pushed
the
feature/ins-5159
branch
from
4517a7f to
82d5eb2
Compare
…function for storage type labels
…nd update related logic
…date related logic
…ve cloud sync logic
…d synchronization
…nation logic and add isSwitchingStorageType function
…ameter assignment
…selection and improve project modal submission logic
pavkout
force-pushed
the
feature/ins-5159
branch
from
596735a to
301e47d
Compare
marckong
approved these changes
Apr 10, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
] (#8548) * Modify types and create new default values for storage rules * Refactor project storage type handling to use StorageRules and add a function for storage type labels * Refactor ProjectDropdown to use StorageRules and update project storage type handling * Refactor NewWorkspaceModal to use StorageRules for storage handling * Refactor ProjectModal to use StorageRules for storage type handling and update related logic * Refactor WorkspaceSettingsModal to use StorageRules for organization storage handling * Refactor ProjectRoute to use StorageRules for storage handling and update related logic * Refactor import route to utilize organization storage rules and improve cloud sync logic * Refactor sync logic in import route to utilize storage rules for cloud synchronization * Refactor ProjectModal and ProjectRoute to improve storage type messaging clarity * Refactor getDefaultProjectStorageType to enhance storage type determination logic and add isSwitchingStorageType function * Refactor fetchAndCacheOrganizationStorageRule to simplify default parameter assignment * Refactor storageRule to include cloud sync, Git sync, and local vault options * Refactor ProjectModal to update project data based on storage rules * Refactor ProjectModal to manage storage type state directly and improve data handling * Refactor dashboard interactions tests to use first() for project row selection and improve project modal submission logic * Fix inconsistency check for Git projects in ProjectDropdown component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The electron application should only enable what is allowed set by the API.
Closes INS-5159