fix: exclude environment workspaces from Move/Copy to Workspace dropdown#9737
Open
BloodShop wants to merge 1 commit intoKong:developfrom
Open
fix: exclude environment workspaces from Move/Copy to Workspace dropdown#9737BloodShop wants to merge 1 commit intoKong:developfrom
BloodShop wants to merge 1 commit intoKong:developfrom
Conversation
- Updated workspace filtering logic to exclude environment workspaces - Only design, collection, and mcp workspaces are now shown in the dropdown - Fixes confusion where users saw environments instead of actual workspaces - Applied to both request-settings-modal and request-group-settings-modal Fixes Kong#8837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #8837 by correcting the workspace filtering logic in the Move/Copy to Workspace dropdown to exclude environment workspaces.
Problem
When users tried to move or copy requests to different workspaces, the dropdown was incorrectly populated with environments instead of actual workspaces. This made it impossible to properly move requests between workspaces.
Root Cause
The workspace filtering logic was only excluding
mock-serverworkspaces but was accidentally includingenvironmentworkspaces, which are not valid destinations for moving/copying requests.Solution
Updated the workspace filter in both modal components to exclude environment workspaces:
Before:
After:
Files Modified
packages/insomnia/src/ui/components/modals/request-settings-modal.tsxpackages/insomnia/src/ui/components/modals/request-group-settings-modal.tsxBenefits
Testing
Verified that the filtering logic correctly excludes both
mock-serverandenvironmentworkspaces while preserving valid workspace types.Fixes #8837